Attachment #122710 for bug #76426

View Details Raw Unified Return to Bug 76426



2012-01-16  Hajime Morrita  <morrita@chromium.org>

        [Internals] member varaibles should follow naming convention.
        https://bugs.webkit.org/show_bug.cgi?id=76426

        Reviewed by NOBODY (OOPS!).

        No new tests. Just a rename.

        * testing/Internals.cpp:
        (WebCore::Internals::Internals):
        (WebCore::Internals::setPasswordEchoEnabled):
        (WebCore::Internals::setPasswordEchoDurationInSeconds):
        (WebCore::Internals::reset):
        * testing/Internals.h:

2012-01-16  Enrica Casucci  <enrica@apple.com>

        REGRESSION: r102553 Autocorrection bubble doesn't show up



}

Internals::Internals()
    : m_passwordEchoDurationInSecondsBackup(0)
    , m_passwordEchoDurationInSecondsBackedUp(false)
    , m_passwordEchoEnabledBackedUp(false)
{
}


        return;
    }

    if (!m_passwordEchoEnabledBackedUp) {
        m_passwordEchoEnabledBackup = document->settings()->passwordEchoEnabled();
        m_passwordEchoEnabledBackedUp = true;
    }
    document->settings()->setPasswordEchoEnabled(enabled);
}

        return;
    }

    if (!m_passwordEchoDurationInSecondsBackedUp) {
        m_passwordEchoDurationInSecondsBackup = document->settings()->passwordEchoDurationInSeconds();
        m_passwordEchoDurationInSecondsBackedUp = true;
    }
    document->settings()->setPasswordEchoDurationInSeconds(durationInSeconds);
}

    if (!document || !document->settings())
        return;

    if (m_passwordEchoDurationInSecondsBackedUp) {
        document->settings()->setPasswordEchoDurationInSeconds(m_passwordEchoDurationInSecondsBackup);
        m_passwordEchoDurationInSecondsBackedUp = false;
    }

    if (m_passwordEchoEnabledBackedUp) {
        document->settings()->setPasswordEchoEnabled(m_passwordEchoEnabledBackup);
        m_passwordEchoEnabledBackedUp = false;
    }

    if (Page* page = document->page())



private:
    Internals();

    double m_passwordEchoDurationInSecondsBackup;
    bool m_passwordEchoEnabledBackup : 1;
    bool m_passwordEchoDurationInSecondsBackedUp : 1;
    bool m_passwordEchoEnabledBackedUp : 1;
};

} // namespace WebCore

Return to Bug 76426

Lines 113-120 Internals::~Internals() a/Source/WebCore/testing/Internals.cpp_sec1
- a/Source/WebCore/testing/Internals.cpp -14 / +15 lines
113	}	113	}
114		114
115	Internals::Internals()	115	Internals::Internals()
116	: passwordEchoDurationInSecondsBackedUp(false)	116	: m_passwordEchoDurationInSecondsBackup(0)
117	, passwordEchoEnabledBackedUp(false)	117	, m_passwordEchoDurationInSecondsBackedUp(false)
		118	, m_passwordEchoEnabledBackedUp(false)
118	{	119	{
119	}	120	}
120		121
Lines 397-405 void Internals::setPasswordEchoEnabled(Document* document, bool enabled, Excepti a/Source/WebCore/testing/Internals.cpp_sec2
397	return;	398	return;
398	}	399	}
399		400
400	if (!passwordEchoEnabledBackedUp) {	401	if (!m_passwordEchoEnabledBackedUp) {
401	passwordEchoEnabledBackup = document->settings()->passwordEchoEnabled();	402	m_passwordEchoEnabledBackup = document->settings()->passwordEchoEnabled();
402	passwordEchoEnabledBackedUp = true;	403	m_passwordEchoEnabledBackedUp = true;
403	}	404	}
404	document->settings()->setPasswordEchoEnabled(enabled);	405	document->settings()->setPasswordEchoEnabled(enabled);
405	}	406	}
Lines 411-419 void Internals::setPasswordEchoDurationInSeconds(Document* document, double dura a/Source/WebCore/testing/Internals.cpp_sec3
411	return;	412	return;
412	}	413	}
413		414
414	if (!passwordEchoDurationInSecondsBackedUp) {	415	if (!m_passwordEchoDurationInSecondsBackedUp) {
415	passwordEchoDurationInSecondsBackup = document->settings()->passwordEchoDurationInSeconds();	416	m_passwordEchoDurationInSecondsBackup = document->settings()->passwordEchoDurationInSeconds();
416	passwordEchoDurationInSecondsBackedUp = true;	417	m_passwordEchoDurationInSecondsBackedUp = true;
417	}	418	}
418	document->settings()->setPasswordEchoDurationInSeconds(durationInSeconds);	419	document->settings()->setPasswordEchoDurationInSeconds(durationInSeconds);
419	}	420	}
Lines 465-478 void Internals::reset(Document* document) a/Source/WebCore/testing/Internals.cpp_sec4
465	if (!document \|\| !document->settings())	466	if (!document \|\| !document->settings())
466	return;	467	return;
467		468
468	if (passwordEchoDurationInSecondsBackedUp) {	469	if (m_passwordEchoDurationInSecondsBackedUp) {
469	document->settings()->setPasswordEchoDurationInSeconds(passwordEchoDurationInSecondsBackup);	470	document->settings()->setPasswordEchoDurationInSeconds(m_passwordEchoDurationInSecondsBackup);
470	passwordEchoDurationInSecondsBackedUp = false;	471	m_passwordEchoDurationInSecondsBackedUp = false;
471	}	472	}
472		473
473	if (passwordEchoEnabledBackedUp) {	474	if (m_passwordEchoEnabledBackedUp) {
474	document->settings()->setPasswordEchoEnabled(passwordEchoEnabledBackup);	475	document->settings()->setPasswordEchoEnabled(m_passwordEchoEnabledBackup);
475	passwordEchoEnabledBackedUp = false;	476	m_passwordEchoEnabledBackedUp = false;
476	}	477	}
477		478
478	if (Page* page = document->page())	479	if (Page* page = document->page())

Lines 122-131 public: a/Source/WebCore/testing/Internals.h_sec1
- a/Source/WebCore/testing/Internals.h -4 / +4 lines
122	private:	122	private:
123	Internals();	123	Internals();
124		124
125	double passwordEchoDurationInSecondsBackup;	125	double m_passwordEchoDurationInSecondsBackup;
126	bool passwordEchoEnabledBackup : 1;	126	bool m_passwordEchoEnabledBackup : 1;
127	bool passwordEchoDurationInSecondsBackedUp : 1;	127	bool m_passwordEchoDurationInSecondsBackedUp : 1;
128	bool passwordEchoEnabledBackedUp : 1;	128	bool m_passwordEchoEnabledBackedUp : 1;
129	};	129	};
130		130
131	} // namespace WebCore	131	} // namespace WebCore

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +16 lines
		1	2012-01-16 Hajime Morrita <morrita@chromium.org>
		2
		3	[Internals] member varaibles should follow naming convention.
		4	https://bugs.webkit.org/show_bug.cgi?id=76426
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	No new tests. Just a rename.
		9
		10	* testing/Internals.cpp:
		11	(WebCore::Internals::Internals):
		12	(WebCore::Internals::setPasswordEchoEnabled):
		13	(WebCore::Internals::setPasswordEchoDurationInSeconds):
		14	(WebCore::Internals::reset):
		15	* testing/Internals.h:
		16
1	2012-01-16 Enrica Casucci <enrica@apple.com>	17	2012-01-16 Enrica Casucci <enrica@apple.com>
2		18
3	REGRESSION: r102553 Autocorrection bubble doesn't show up	19	REGRESSION: r102553 Autocorrection bubble doesn't show up