Attachment #282110 for bug #158831

View Details Raw Unified Return to Bug 158831

| Differences between



2016-06-27  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
        https://bugs.webkit.org/show_bug.cgi?id=158831

        Reviewed by NOBODY (OOPS!).

        * fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt:
        Flip some result lines from FAIL to PASS.

2016-06-23  Benjamin Poulain  <bpoulain@apple.com>

        OOM Assertion failure in Array.prototype.toString



PASS promise webkitRTCPeerConnection.prototype.setRemoteDescription.call({}) rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise webkitRTCPeerConnection.prototype.addIceCandidate.call({}) rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise webkitRTCPeerConnection.prototype.getStats.call({}, null) rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise objectWithPcPrototype.createOffer() rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise objectWithPcPrototype.createAnswer() rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise objectWithPcPrototype.setLocalDescription() rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise objectWithPcPrototype.setRemoteDescription() rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise objectWithPcPrototype.addIceCandidate() rejected with TypeError: Function should be called on an RTCPeerConnection
PASS promise objectWithPcPrototype.getStats() rejected with TypeError: Function should be called on an RTCPeerConnection
FAIL promise pcWithEmptyPrototype.createOffer() fulfilled unexpectedly.
FAIL promise pcWithEmptyPrototype.createAnswer() rejected with Error: InvalidStateError: DOM Exception 11; expected reason TypeError: Function should be called on an RTCPeerConnection
FAIL promise pcWithEmptyPrototype.setLocalDescription() rejected with TypeError: Not enough arguments; expected reason TypeError: Function should be called on an RTCPeerConnection



2016-06-27  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
        https://bugs.webkit.org/show_bug.cgi?id=158831

        Reviewed by NOBODY (OOPS!).

        Use @operations slot in RTCPeerConnection type check.

        Updated results of existing test.

        * Modules/mediastream/RTCPeerConnection.js:
        (initializeRTCPeerConnection):
        Initialize @operations slot in constructor.
        * Modules/mediastream/RTCPeerConnectionInternals.js:
        (isRTCPeerConnection):
        Use @operations slot in type check.

2016-06-23  Brady Eidson  <beidson@apple.com>

        Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)

Lines 49-54 function initializeRTCPeerConnection(configuration) a/Source/WebCore/Modules/mediastream/RTCPeerConnection.js_sec1
- a/Source/WebCore/Modules/mediastream/RTCPeerConnection.js +1 lines
49	throw new @TypeError(message);	49	throw new @TypeError(message);
50	}	50	}
51		51
		52	this.@operations = [];
52	this.@localStreams = [];	53	this.@localStreams = [];
53		54
54	return this;	55	return this;



{
    "use strict";

    if (!peerConnection.@operations)
        peerConnection.@operations = [];

    const operations = peerConnection.@operations;

    function runNext() {

{
    "use strict";

    return @isObject(connection) && !!connection.@operations;
    return @isObject(connection) && !!connection.@queuedCreateOffer;
}

Return to Bug 158831

Lines 36-44 function enqueueOperation(peerConnection, operation) a/Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js_sec1
- a/Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js -5 / +1 lines
36	{	36	{
37	"use strict";	37	"use strict";
38		38
39	if (!peerConnection.@operations)
40	peerConnection.@operations = [];
41
42	const operations = peerConnection.@operations;	39	const operations = peerConnection.@operations;
43		40
44	function runNext() {	41	function runNext() {
Lines 133-138 function isRTCPeerConnection(connection) a/Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js_sec2
133	{	130	{
134	"use strict";	131	"use strict";
135		132
136	// FIXME: Robustify this check (http://webkit.org/b/158831)	133	return @isObject(connection) && !!connection.@operations;
137	return @isObject(connection) && !!connection.@queuedCreateOffer;
138	}	134	}

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +10 lines
		1	2016-06-27 Adam Bergkvist <adam.bergkvist@ericsson.com>
		2
		3	WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
		4	https://bugs.webkit.org/show_bug.cgi?id=158831
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt:
		9	Flip some result lines from FAIL to PASS.
		10
1	2016-06-23 Benjamin Poulain <bpoulain@apple.com>	11	2016-06-23 Benjamin Poulain <bpoulain@apple.com>
2		12
3	OOM Assertion failure in Array.prototype.toString	13	OOM Assertion failure in Array.prototype.toString

Lines 9-20 PASS promise webkitRTCPeerConnection.prototype.setLocalDescription.call({}) reje a/LayoutTests/fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt_sec1
- a/LayoutTests/fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt -6 / +6 lines
9	PASS promise webkitRTCPeerConnection.prototype.setRemoteDescription.call({}) rejected with TypeError: Function should be called on an RTCPeerConnection	9	PASS promise webkitRTCPeerConnection.prototype.setRemoteDescription.call({}) rejected with TypeError: Function should be called on an RTCPeerConnection
10	PASS promise webkitRTCPeerConnection.prototype.addIceCandidate.call({}) rejected with TypeError: Function should be called on an RTCPeerConnection	10	PASS promise webkitRTCPeerConnection.prototype.addIceCandidate.call({}) rejected with TypeError: Function should be called on an RTCPeerConnection
11	PASS promise webkitRTCPeerConnection.prototype.getStats.call({}, null) rejected with TypeError: Function should be called on an RTCPeerConnection	11	PASS promise webkitRTCPeerConnection.prototype.getStats.call({}, null) rejected with TypeError: Function should be called on an RTCPeerConnection
12	FAIL promise objectWithPcPrototype.createOffer() rejected with TypeError: Can only call RTCPeerConnection.queuedCreateOffer on instances of RTCPeerConnection; expected reason TypeError: Function should be called on an RTCPeerConnection	12	PASS promise objectWithPcPrototype.createOffer() rejected with TypeError: Function should be called on an RTCPeerConnection
13	FAIL promise objectWithPcPrototype.createAnswer() rejected with TypeError: Can only call RTCPeerConnection.queuedCreateAnswer on instances of RTCPeerConnection; expected reason TypeError: Function should be called on an RTCPeerConnection	13	PASS promise objectWithPcPrototype.createAnswer() rejected with TypeError: Function should be called on an RTCPeerConnection
14	FAIL promise objectWithPcPrototype.setLocalDescription() rejected with TypeError: Not enough arguments; expected reason TypeError: Function should be called on an RTCPeerConnection	14	PASS promise objectWithPcPrototype.setLocalDescription() rejected with TypeError: Function should be called on an RTCPeerConnection
15	FAIL promise objectWithPcPrototype.setRemoteDescription() rejected with TypeError: Not enough arguments; expected reason TypeError: Function should be called on an RTCPeerConnection	15	PASS promise objectWithPcPrototype.setRemoteDescription() rejected with TypeError: Function should be called on an RTCPeerConnection
16	FAIL promise objectWithPcPrototype.addIceCandidate() rejected with TypeError: Not enough arguments; expected reason TypeError: Function should be called on an RTCPeerConnection	16	PASS promise objectWithPcPrototype.addIceCandidate() rejected with TypeError: Function should be called on an RTCPeerConnection
17	FAIL promise objectWithPcPrototype.getStats() rejected with TypeError: Can only call RTCPeerConnection.privateGetStats on instances of RTCPeerConnection; expected reason TypeError: Function should be called on an RTCPeerConnection	17	PASS promise objectWithPcPrototype.getStats() rejected with TypeError: Function should be called on an RTCPeerConnection
18	FAIL promise pcWithEmptyPrototype.createOffer() fulfilled unexpectedly.	18	FAIL promise pcWithEmptyPrototype.createOffer() fulfilled unexpectedly.
19	FAIL promise pcWithEmptyPrototype.createAnswer() rejected with Error: InvalidStateError: DOM Exception 11; expected reason TypeError: Function should be called on an RTCPeerConnection	19	FAIL promise pcWithEmptyPrototype.createAnswer() rejected with Error: InvalidStateError: DOM Exception 11; expected reason TypeError: Function should be called on an RTCPeerConnection
20	FAIL promise pcWithEmptyPrototype.setLocalDescription() rejected with TypeError: Not enough arguments; expected reason TypeError: Function should be called on an RTCPeerConnection	20	FAIL promise pcWithEmptyPrototype.setLocalDescription() rejected with TypeError: Not enough arguments; expected reason TypeError: Function should be called on an RTCPeerConnection

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +18 lines
		1	2016-06-27 Adam Bergkvist <adam.bergkvist@ericsson.com>
		2
		3	WebRTC: Robustify 'this' type check in RTCPeerConnection JS built-ins
		4	https://bugs.webkit.org/show_bug.cgi?id=158831
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Use @operations slot in RTCPeerConnection type check.
		9
		10	Updated results of existing test.
		11
		12	* Modules/mediastream/RTCPeerConnection.js:
		13	(initializeRTCPeerConnection):
		14	Initialize @operations slot in constructor.
		15	* Modules/mediastream/RTCPeerConnectionInternals.js:
		16	(isRTCPeerConnection):
		17	Use @operations slot in type check.
		18
1	2016-06-23 Brady Eidson <beidson@apple.com>	19	2016-06-23 Brady Eidson <beidson@apple.com>
2		20
3	Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)	21	Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)