Attachment #71623 for bug #48172

View Details Raw Unified Return to Bug 48172



2010-10-22  Amruth Raj/Ravi Kasibhatla  <amruthraj@motorola.com/ravi.kasibhatla@motorola.com>

        Reviewed by NOBODY (OOPS!).

        Adding the WebKit2/UIProcess/gtk as a exception for style checking.
        The folder has two files WebViewInternal.h and WebViewInternal.cpp
        which follow GTK naming convention.

        * Scripts/webkitpy/style/checker.py: Added the exception of folder WebKit2/UIProcess/gtk for GTK naming convention.
        * Scripts/webkitpy/style/checker_unittest.py: Added a unit test case assertNoCheck for WebKit2/UIProcess/gtk/WebViewInternal.h

2010-10-19  Eric Seidel  <eric@webkit.org>

        Unreviewed.

Lines 136-141 _PATH_RULES_SPECIFIER = [ WebKitTools/Scripts/webkitpy/style/checker.py_sec1
- WebKitTools/Scripts/webkitpy/style/checker.py +1 lines
136	# Also, GTK+ allows the use of NULL.	136	# Also, GTK+ allows the use of NULL.
137	"WebCore/bindings/scripts/test/GObject",	137	"WebCore/bindings/scripts/test/GObject",
138	"WebKit/gtk/webkit/",	138	"WebKit/gtk/webkit/",
		139	"WebKit2/UIProcess/gtk/",
139	"WebKitTools/DumpRenderTree/gtk/"],	140	"WebKitTools/DumpRenderTree/gtk/"],
140	["-readability/naming",	141	["-readability/naming",
141	"-readability/null"]),	142	"-readability/null"]),

Lines 222-227 class GlobalVariablesTest(unittest.TestC WebKitTools/Scripts/webkitpy/style/checker_unittest.py_sec1
- WebKitTools/Scripts/webkitpy/style/checker_unittest.py +2 lines
222	"readability/naming")	222	"readability/naming")
223	assertNoCheck("WebKit/gtk/webkit/webkit.h",	223	assertNoCheck("WebKit/gtk/webkit/webkit.h",
224	"readability/naming")	224	"readability/naming")
		225	assertNoCheck("WebKit2/UIProcess/gtk/WebViewInternal.h",
		226	"readability/naming")
225	assertNoCheck("WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp",	227	assertNoCheck("WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp",
226	"readability/null")	228	"readability/null")
227	assertNoCheck("WebKit/efl/ewk/ewk_view.h",	229	assertNoCheck("WebKit/efl/ewk/ewk_view.h",

Return to Bug 48172

Lines 1-3 WebKitTools/ChangeLog_sec1
- WebKitTools/ChangeLog +11 lines
		1	2010-10-22 Amruth Raj/Ravi Kasibhatla <amruthraj@motorola.com/ravi.kasibhatla@motorola.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Adding the WebKit2/UIProcess/gtk as a exception for style checking.
		6	The folder has two files WebViewInternal.h and WebViewInternal.cpp
		7	which follow GTK naming convention.
		8
		9	* Scripts/webkitpy/style/checker.py: Added the exception of folder WebKit2/UIProcess/gtk for GTK naming convention.
		10	* Scripts/webkitpy/style/checker_unittest.py: Added a unit test case assertNoCheck for WebKit2/UIProcess/gtk/WebViewInternal.h
		11
1	2010-10-19 Eric Seidel <eric@webkit.org>	12	2010-10-19 Eric Seidel <eric@webkit.org>
2		13
3	Unreviewed.	14	Unreviewed.