Attachment #85818 for bug #52952

View Details Raw Unified Return to Bug 52952

| Differences between



2011-03-15  ChangSeok Oh  <shivamidow@gmail.com>

        Reviewed by NOBODY (OOPS!).

        Wrong tab focused region
        https://bugs.webkit.org/show_bug.cgi?id=52952

        Test: fast/repaint/outline-focus-anchor-image.html

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paintOutline):
        (WebCore::RenderInline::paintOutlineForLine):

2011-03-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

Lines 1033-1038 void RenderInline::paintOutline(Graphics Source/WebCore/rendering/RenderInline.cpp_sec1
- Source/WebCore/rendering/RenderInline.cpp -1 / +8 lines
1033	RootInlineBox* root = curr->root();	1033	RootInlineBox* root = curr->root();
1034	int top = max(root->lineTop(), curr->logicalTop());	1034	int top = max(root->lineTop(), curr->logicalTop());
1035	int bottom = min(root->lineBottom(), curr->logicalBottom());	1035	int bottom = min(root->lineBottom(), curr->logicalBottom());
		1036
		1037	for (RenderObject* currRenderObj = firstChild(); currRenderObj; currRenderObj = currRenderObj->nextSibling()) {
		1038	if (!currRenderObj->isText() && !currRenderObj->isListMarker()) {
		1039	top = min(top, toRenderBox(currRenderObj)->logicalTop());
		1040	bottom = max(bottom, toRenderBox(currRenderObj)->logicalBottom());
		1041	}
		1042	}
1036	rects.append(IntRect(curr->x(), top, curr->logicalWidth(), bottom - top));	1043	rects.append(IntRect(curr->x(), top, curr->logicalWidth(), bottom - top));
1037	}	1044	}
1038	rects.append(IntRect());	1045	rects.append(IntRect());
Lines 1055-1061 void RenderInline::paintOutlineForLine(G Source/WebCore/rendering/RenderInline.cpp_sec2
1055	int l = tx + thisline.x() - offset;	1062	int l = tx + thisline.x() - offset;
1056	int b = ty + thisline.maxY() + offset;	1063	int b = ty + thisline.maxY() + offset;
1057	int r = tx + thisline.maxX() + offset;	1064	int r = tx + thisline.maxX() + offset;
1058		1065
1059	// left edge	1066	// left edge
1060	drawLineForBoxSide(graphicsContext,	1067	drawLineForBoxSide(graphicsContext,
1061	l - ow,	1068	l - ow,



2011-03-15  ChangSeok Oh  <shivamidow@gmail.com>

        Reviewed by NOBODY (OOPS!).

        Wrong tab focused region
        https://bugs.webkit.org/show_bug.cgi?id=52952

        * fast/repaint/outline-focus-anchor-image.html: Added.
        * platform/mac/fast/repaint/outline-focus-anchor-image-expected.png: Added.
        * platform/mac/fast/repaint/outline-focus-anchor-image-expected.txt: Added.

2011-03-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.



<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
<html>
  <head>
    <title>CSS 2.1 Test Suite: outline</title>
    <link rel="help" href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
    <style>
      a:focus { outline: 3px solid red; }
    </style>
    <script>
    function runTest()
    {
        var parentAnchor = document.getElementById('ID_parentAnchor');
        parentAnchor.focus();
    }
    </script>
   </head>
   <body onload="runTest();" style="background-color:#000000;">
     <a id="ID_parentAnchor" href="#">
       <img src="resources/apple.jpg" />
     </a>
   </body>
</html>



layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x252
  RenderBlock {HTML} at (0,0) size 800x252
    RenderBody {BODY} at (8,8) size 784x236 [bgcolor=#000000]
      RenderInline {A} at (0,0) size 214x18 [color=#0000EE]
        RenderText {#text} at (0,0) size 0x0
        RenderImage {IMG} at (0,0) size 214x232
        RenderText {#text} at (0,0) size 0x0
      RenderText {#text} at (0,0) size 0x0

Return to Bug 52952

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +13 lines
		1	2011-03-15 ChangSeok Oh <shivamidow@gmail.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Wrong tab focused region
		6	https://bugs.webkit.org/show_bug.cgi?id=52952
		7
		8	Test: fast/repaint/outline-focus-anchor-image.html
		9
		10	* rendering/RenderInline.cpp:
		11	(WebCore::RenderInline::paintOutline):
		12	(WebCore::RenderInline::paintOutlineForLine):
		13
1	2011-03-12 Pavel Podivilov <podivilov@chromium.org>	14	2011-03-12 Pavel Podivilov <podivilov@chromium.org>
2		15
3	Reviewed by Yury Semikhatsky.	16	Reviewed by Yury Semikhatsky.

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +11 lines
		1	2011-03-15 ChangSeok Oh <shivamidow@gmail.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Wrong tab focused region
		6	https://bugs.webkit.org/show_bug.cgi?id=52952
		7
		8	* fast/repaint/outline-focus-anchor-image.html: Added.
		9	* platform/mac/fast/repaint/outline-focus-anchor-image-expected.png: Added.
		10	* platform/mac/fast/repaint/outline-focus-anchor-image-expected.txt: Added.
		11
1	2011-03-12 Pavel Podivilov <podivilov@chromium.org>	12	2011-03-12 Pavel Podivilov <podivilov@chromium.org>
2		13
3	Reviewed by Yury Semikhatsky.	14	Reviewed by Yury Semikhatsky.

Line 0 LayoutTests/fast/repaint/outline-focus-anchor-image.html_sec1
- LayoutTests/fast/repaint/outline-focus-anchor-image.html +22 lines
	1	<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
	2	<html>
	3	<head>
	4	<title>CSS 2.1 Test Suite: outline</title>
	5	<link rel="help" href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
	6	<style>
	7	a:focus { outline: 3px solid red; }
	8	</style>
	9	<script>
	10	function runTest()
	11	{
	12	var parentAnchor = document.getElementById('ID_parentAnchor');
	13	parentAnchor.focus();
	14	}
	15	</script>
	16	</head>
	17	<body onload="runTest();" style="background-color:#000000;">
	18	<a id="ID_parentAnchor" href="#">
	19	<img src="resources/apple.jpg" />
	20	</a>
	21	</body>
	22	</html>

Line 0 LayoutTests/platform/mac/fast/repaint/outline-focus-anchor-image-expected.txt_sec1
- LayoutTests/platform/mac/fast/repaint/outline-focus-anchor-image-expected.txt +10 lines
	1	layer at (0,0) size 800x600
	2	RenderView at (0,0) size 800x600
	3	layer at (0,0) size 800x252
	4	RenderBlock {HTML} at (0,0) size 800x252
	5	RenderBody {BODY} at (8,8) size 784x236 [bgcolor=#000000]
	6	RenderInline {A} at (0,0) size 214x18 [color=#0000EE]
	7	RenderText {#text} at (0,0) size 0x0
	8	RenderImage {IMG} at (0,0) size 214x232
	9	RenderText {#text} at (0,0) size 0x0
	10	RenderText {#text} at (0,0) size 0x0