Bug 154471

Summary: Web Inspector: color swatch and border are misaligned in Visual Styles sidebar
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, dstrokis, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Screenshot of the Bug
none
Patch
none
[image] Left corners rounded
none
Patch none

Timothy Hatcher
Reported 2016-02-19 14:18:52 PST
Created attachment 271799 [details] Screenshot of the Bug Steps: 1) Open Visual Styles sidebar 2) Show Text > Style section 3) Resize sidebar, and notice the border shifts on the swatch Results: Border shifts depending on the switch of the sidebar Expected: Border stays in the same position always Note: This could be a WebKit bug or a sub-pixel layout issues we need to workaround.
Attachments
Screenshot of the Bug (11.44 KB, image/png)
2016-02-19 14:18 PST, Timothy Hatcher 		no flags
Details
Patch (2.63 KB, patch)
2016-03-09 16:37 PST, Daniel Strokis 		no flags
DetailsFormatted DiffDiff
[image] Left corners rounded (307.98 KB, image/png)
2016-03-09 17:20 PST, Matt Baker 		no flags
Details
Patch (2.43 KB, patch)
2016-03-10 15:06 PST, Daniel Strokis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-19 14:19:29 PST
<rdar://problem/24749596>
Timothy Hatcher
Comment 2 2016-02-19 14:20:01 PST
See bug 148106 for my original report of this.
Daniel Strokis
Comment 3 2016-03-09 16:37:11 PST
Created attachment 273508 [details] Patch
Matt Baker
Comment 4 2016-03-09 17:20:34 PST
Created attachment 273514 [details] [image] Left corners rounded Looking good. One suggestion: what if we tried applying the radius to just the left corners?
Daniel Strokis
Comment 5 2016-03-09 17:34:00 PST
That would look consistent with the other swatches & buttons in the Inspector, which I think looks good.
Timothy Hatcher
Comment 6 2016-03-09 20:39:12 PST
(In reply to comment #4) > Created attachment 273514 [details] > [image] Left corners rounded > > Looking good. One suggestion: what if we tried applying the radius to just > the left corners? I like it left-side only.
Daniel Strokis
Comment 7 2016-03-10 15:06:00 PST
Created attachment 273629 [details] Patch
WebKit Commit Bot
Comment 8 2016-03-10 17:03:28 PST
Comment on attachment 273629 [details] Patch Clearing flags on attachment: 273629 Committed r197975: <http://trac.webkit.org/changeset/197975>
WebKit Commit Bot
Comment 9 2016-03-10 17:03:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.