Bug 162583

Summary:

Exception unwinding code should use a CatchScope instead of a ThrowScope.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
proposed patch.	ggaren: review+

Mark Lam

Reported 2016-09-26 16:05:13 PDT

This is because the exception unwinding code does not throw an exception. It only inspects the exception and passes it to the appropriate handler.

Attachments
proposed patch. (2.03 KB, patch) 2016-09-26 16:10 PDT, Mark Lam	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2016-09-26 16:10:04 PDT

Geoffrey Garen

Comment 2 2016-09-26 16:11:57 PDT

Comment on attachment 289885 [details] proposed patch. r=me

Mark Lam

Comment 3 2016-09-26 16:14:57 PDT

Thanks for the review. Landed in r206401: <http://trac.webkit.org/r206401>.

Note You need to log in before you can comment on or make changes to this bug.