Bug 188147

Summary: Make CompositeOperator and BlendMode into 8-bit enum classes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: achristensen, darin, ews-watchlist, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 186751    
Bug Blocks:    
Attachments:
Description Flags
Patch
darin: review+
Patch
none
Patch
none
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra
none
Archive of layout-test-results from ews113 for mac-sierra
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews126 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2018-07-29 08:28:50 PDT
Make CompositeOperator and BlendMode into 8-bit enum classes
Attachments
Patch (134.74 KB, patch)
2018-07-29 08:30 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
Patch (134.75 KB, patch)
2018-07-30 09:41 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (136.49 KB, patch)
2018-07-30 09:48 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (136.82 KB, patch)
2018-07-30 10:16 PDT, Simon Fraser (smfr) 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-sierra (2.49 MB, application/zip)
2018-07-30 11:31 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews113 for mac-sierra (3.23 MB, application/zip)
2018-07-30 11:59 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.53 MB, application/zip)
2018-07-30 12:21 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.74 MB, application/zip)
2018-07-30 13:28 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.33 MB, application/zip)
2018-07-30 13:58 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (12.99 MB, application/zip)
2018-07-30 14:08 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-07-29 08:30:52 PDT
Created attachment 346029 [details] Patch
Darin Adler
Comment 2 2018-07-29 12:19:43 PDT
Comment on attachment 346029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346029&action=review > Source/WebCore/html/HTMLImageElement.cpp:70 > + , m_compositeOperator(CompositeOperator::SourceOver) Do this in the header instead? > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:202 > + , globalComposite(CompositeOperator::SourceOver) > + , globalBlend(BlendMode::Normal) Do these in the class definition instead of the constructor?
Simon Fraser (smfr)
Comment 3 2018-07-30 09:41:12 PDT
Created attachment 346063 [details] Patch
Simon Fraser (smfr)
Comment 4 2018-07-30 09:48:36 PDT
Created attachment 346064 [details] Patch
Simon Fraser (smfr)
Comment 5 2018-07-30 10:16:59 PDT
Created attachment 346065 [details] Patch
EWS Watchlist
Comment 6 2018-07-30 11:31:46 PDT
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8700661 New failing tests: svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/animations/svgenum-animation-11.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
EWS Watchlist
Comment 7 2018-07-30 11:31:48 PDT
Created attachment 346077 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Simon Fraser (smfr)
Comment 8 2018-07-30 11:55:19 PDT
SVG tests are failing because: template<typename EnumType> class SVGAnimatedEnumerationPropertyTearOff final : public SVGAnimatedStaticPropertyTearOff<unsigned> { fails badly if EnumType is 8-bit; we're casting an 8-bit enum to unsigned and taking a reference
EWS Watchlist
Comment 9 2018-07-30 11:59:40 PDT
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8700709 New failing tests: svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/animations/svgenum-animation-11.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
EWS Watchlist
Comment 10 2018-07-30 11:59:41 PDT
Created attachment 346079 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 11 2018-07-30 12:21:45 PDT
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8700818 New failing tests: svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html
EWS Watchlist
Comment 12 2018-07-30 12:21:47 PDT
Created attachment 346083 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 13 2018-07-30 13:28:20 PDT
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8702131 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html svg/animations/svgenum-animation-11.html
EWS Watchlist
Comment 14 2018-07-30 13:28:21 PDT
Created attachment 346094 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 15 2018-07-30 13:58:20 PDT
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8702368 New failing tests: svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/animations/svgenum-animation-11.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
EWS Watchlist
Comment 16 2018-07-30 13:58:21 PDT
Created attachment 346098 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 17 2018-07-30 14:08:37 PDT
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8702250 New failing tests: svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
EWS Watchlist
Comment 18 2018-07-30 14:08:39 PDT
Created attachment 346099 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Alex Christensen
Comment 19 2018-08-06 11:31:09 PDT
*** This bug has been marked as a duplicate of bug 188325 ***
Note You need to log in before you can comment on or make changes to this bug.