Bug 188325

Summary: Make BlendMode an enum class
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2018-08-03 18:08:13 PDT
Make BlendMode an enum class
Attachments
Patch (55.02 KB, patch)
2018-08-03 18:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (74.37 KB, patch)
2018-08-03 18:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-03 18:10:09 PDT
Created attachment 346571 [details] Patch
Alex Christensen
Comment 2 2018-08-03 18:34:37 PDT
Created attachment 346574 [details] Patch
Simon Fraser (smfr)
Comment 3 2018-08-03 20:34:33 PDT
I did this in bug 188147 but it broke SVG animation tests. How does yours not?
Alex Christensen
Comment 4 2018-08-06 10:51:52 PDT
Comment on attachment 346574 [details] Patch ¯\_(ツ)_/¯
WebKit Commit Bot
Comment 5 2018-08-06 11:19:51 PDT
Comment on attachment 346574 [details] Patch Clearing flags on attachment: 346574 Committed r234610: <https://trac.webkit.org/changeset/234610>
WebKit Commit Bot
Comment 6 2018-08-06 11:19:52 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 7 2018-08-06 11:31:09 PDT
*** Bug 188147 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 8 2018-08-06 16:10:40 PDT
<rdar://problem/42985608>
Note You need to log in before you can comment on or make changes to this bug.